Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Uses es6 import/exports #86

Closed
wants to merge 1 commit into from
Closed

Conversation

uniqname
Copy link

@uniqname uniqname commented Dec 7, 2015

This PR changes the source file to an es6 module. It also identifies the source file as an the "main" file for tools that are es6 aware.

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 7, 2015

LGTM 👍

Maybe squash the commits?

@uniqname
Copy link
Author

uniqname commented Dec 9, 2015

Commit squashing appears to be beyond my git-fu. Clearly I need to spend more time in the git dojo.

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 9, 2015

No problem, @uniqname :)

If you want to give it a go, you can try with:

git reset --soft HEAD~3
git commit -m "Use ES6 import/export"

(This will merge the three last commits)

Then force push to your branch:

git push -f

But no problem if you don't get it working.

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 10, 2015

Hi @uniqname, I see you fought the crazy git apis :/ I went ahead and copied the ES6 changes you had done into a new PR: #110.

Thanks for working on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants